Fixes the button size of nuclear bomb interfaces #12070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
TGUI-Changes
EvilDragonfiend
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Honestly I'm not even sure why this happened looking between our code and TG's, they're nearly identical UIs and yet one is properly sized when loaded and the other isn't. It seems like tweaking this thing by 15 pixels solves the issue of the interface clipping over it's bounds to the sides, which is warned about potentially needing to be done in the code comment above the whole thing.
This is how it looks currently, for reference:
Current Annoying UI Look
Why It's Good For The Game
This looks a lot better than before when the buttons were clipping into each other.
Testing Photographs and Procedure
Fixed UI Look
Changelog
🆑
fix: The keypad buttons on nuke interfaces no longer clip into the other buttons
/:cl: